PackageDepSpec cannot be created if package name ends with a hyphen

[ColdWind]

PackageDepSpec? cannot be created if package name ends with a hyphen. PMS specifies doesn't restrict this case.

[ColdWind]

pds-final-hyphens.patch

[ciaranm]

Doesn't this get =cat/foo----2 wrong?

[ColdWind]

Nope. =========== These packages will be installed:

* my.shiny_category-/mypkg-----::local :0-. [N 0-r0] <target> ===========

[ciaranm]

Doesn't this get =cat/foo---- wrong, in that it doesn't throw the right exception?

[ciaranm]

So I don't forget... It's a single hyphen that breaks. Multiple hyphens works.

[ciaranm]

It has come to my attention that I don't have a frickin' clue what that bit of code is playing at. So I think it's time to rewrite the damned thing and remove most of the duplication between elike and user parsing.

[ciaranm]

975ba82125af / d5e5befd325a